fix: fixes the issue with the github action checkout #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3dsm0k3
added a commit
that referenced
this pull request
Jan 15, 2023
* feat: adds init, install and compile commands changes: - adds install command to pull in Docker images - adds init command that initializes a Drogon project - adds compile command that compiles the initialised Drogon project - adds pulling in biolerplates/scaffolding - adds workflows to build Drogon and Gochain images * fix: fixes github action files * fix: fixes Dockerfile and github actions * fix: adds icon/gradle* * fix: fixes github actions * fix: updates github actions to create packages * fix: updates github actions to create packages * fix: fixes github actions to fix permissions * adds docker hub push * fix: fixes the github workflow * fix: fixes the push to the community page * feat: adds support for testing, optimizing changes: - adds 4 new commands - test command to run tests - optimize command to run optimizeJar tasks - deploy command to run deployJar tasks - gradlew subcommand that exposes gradle wrapper to drogon - compile and test command now return CI/CD friendly exit codes - install now pulls docker images from docker hub instead of ghcr.io * fix: adds Docker debian image Changes: - adds Debian Docker image and improves goloop support * fix: fix github actions * feat: adds sandbox, goloop subcommands changes: - adds sandbox start and sandbox stop subcommands - adds goloop command - adds keystore command to generate keystores - restructures code * fix: fixes github actions * fix: fixes github actions * fix: fixes #5 * fix: fixes gochain image * chore: adding dev dependencies and some run scripts to make it easier * chore: removes yarn lock; lets use npm * chore: linter fixes * chore: removes the @typescript-eslint/no-explicit-any; FIX later * chore: fixes the linter warnings; disabled the rules for irrelevant ones * feat: adds ability to generate binary with pkg * fix: fixes the issue with the github action checkout (#7) * fix: gochain build err on docker file (#9) * fix: fixes the issue where the gochain was not getting built inside dockerfile * fix: fixes the image tagging Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com>
r3dsm0k3
added a commit
that referenced
this pull request
Jan 16, 2023
* prepare tsconfig for publish * adds run scripts * linter error fix * 0.1.1 * Revert "0.1.1" This reverts commit f83ceba. * 0.1.1 * 0.1.2 * ability to read the lib version from the package * Milestone 2 (#13) * feat: adds init, install and compile commands changes: - adds install command to pull in Docker images - adds init command that initializes a Drogon project - adds compile command that compiles the initialised Drogon project - adds pulling in biolerplates/scaffolding - adds workflows to build Drogon and Gochain images * fix: fixes github action files * fix: fixes Dockerfile and github actions * fix: adds icon/gradle* * fix: fixes github actions * fix: updates github actions to create packages * fix: updates github actions to create packages * fix: fixes github actions to fix permissions * adds docker hub push * fix: fixes the github workflow * fix: fixes the push to the community page * feat: adds support for testing, optimizing changes: - adds 4 new commands - test command to run tests - optimize command to run optimizeJar tasks - deploy command to run deployJar tasks - gradlew subcommand that exposes gradle wrapper to drogon - compile and test command now return CI/CD friendly exit codes - install now pulls docker images from docker hub instead of ghcr.io * fix: adds Docker debian image Changes: - adds Debian Docker image and improves goloop support * fix: fix github actions * feat: adds sandbox, goloop subcommands changes: - adds sandbox start and sandbox stop subcommands - adds goloop command - adds keystore command to generate keystores - restructures code * fix: fixes github actions * fix: fixes github actions * fix: fixes #5 * fix: fixes gochain image * chore: adding dev dependencies and some run scripts to make it easier * chore: removes yarn lock; lets use npm * chore: linter fixes * chore: removes the @typescript-eslint/no-explicit-any; FIX later * chore: fixes the linter warnings; disabled the rules for irrelevant ones * feat: adds ability to generate binary with pkg * fix: fixes the issue with the github action checkout (#7) * fix: gochain build err on docker file (#9) * fix: fixes the issue where the gochain was not getting built inside dockerfile * fix: fixes the image tagging Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com> * adds installation instructions * adds package name * adds github workflows * updates version from package * chore: bumps version Co-authored-by: coconut-bunch <ajith.c@outlook.com> Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com>
r3dsm0k3
added a commit
that referenced
this pull request
Jan 16, 2023
* feat: adds init, install and compile commands changes: - adds install command to pull in Docker images - adds init command that initializes a Drogon project - adds compile command that compiles the initialised Drogon project - adds pulling in biolerplates/scaffolding - adds workflows to build Drogon and Gochain images * fix: fixes github action files * fix: fixes Dockerfile and github actions * fix: adds icon/gradle* * fix: fixes github actions * fix: updates github actions to create packages * fix: updates github actions to create packages * fix: fixes github actions to fix permissions * adds docker hub push * fix: fixes the github workflow * fix: fixes the push to the community page * feat: adds support for testing, optimizing changes: - adds 4 new commands - test command to run tests - optimize command to run optimizeJar tasks - deploy command to run deployJar tasks - gradlew subcommand that exposes gradle wrapper to drogon - compile and test command now return CI/CD friendly exit codes - install now pulls docker images from docker hub instead of ghcr.io * fix: adds Docker debian image Changes: - adds Debian Docker image and improves goloop support * fix: fix github actions * feat: adds sandbox, goloop subcommands changes: - adds sandbox start and sandbox stop subcommands - adds goloop command - adds keystore command to generate keystores - restructures code * fix: fixes github actions * fix: fixes github actions * fix: fixes #5 * fix: fixes gochain image * chore: adding dev dependencies and some run scripts to make it easier * chore: removes yarn lock; lets use npm * chore: linter fixes * chore: removes the @typescript-eslint/no-explicit-any; FIX later * chore: fixes the linter warnings; disabled the rules for irrelevant ones * feat: adds ability to generate binary with pkg * fix: fixes the issue with the github action checkout (#7) * fix: gochain build err on docker file (#9) * fix: fixes the issue where the gochain was not getting built inside dockerfile * fix: fixes the image tagging * feat: npm package release (#14) * prepare tsconfig for publish * adds run scripts * linter error fix * 0.1.1 * Revert "0.1.1" This reverts commit f83ceba. * 0.1.1 * 0.1.2 * ability to read the lib version from the package * Milestone 2 (#13) * feat: adds init, install and compile commands changes: - adds install command to pull in Docker images - adds init command that initializes a Drogon project - adds compile command that compiles the initialised Drogon project - adds pulling in biolerplates/scaffolding - adds workflows to build Drogon and Gochain images * fix: fixes github action files * fix: fixes Dockerfile and github actions * fix: adds icon/gradle* * fix: fixes github actions * fix: updates github actions to create packages * fix: updates github actions to create packages * fix: fixes github actions to fix permissions * adds docker hub push * fix: fixes the github workflow * fix: fixes the push to the community page * feat: adds support for testing, optimizing changes: - adds 4 new commands - test command to run tests - optimize command to run optimizeJar tasks - deploy command to run deployJar tasks - gradlew subcommand that exposes gradle wrapper to drogon - compile and test command now return CI/CD friendly exit codes - install now pulls docker images from docker hub instead of ghcr.io * fix: adds Docker debian image Changes: - adds Debian Docker image and improves goloop support * fix: fix github actions * feat: adds sandbox, goloop subcommands changes: - adds sandbox start and sandbox stop subcommands - adds goloop command - adds keystore command to generate keystores - restructures code * fix: fixes github actions * fix: fixes github actions * fix: fixes #5 * fix: fixes gochain image * chore: adding dev dependencies and some run scripts to make it easier * chore: removes yarn lock; lets use npm * chore: linter fixes * chore: removes the @typescript-eslint/no-explicit-any; FIX later * chore: fixes the linter warnings; disabled the rules for irrelevant ones * feat: adds ability to generate binary with pkg * fix: fixes the issue with the github action checkout (#7) * fix: gochain build err on docker file (#9) * fix: fixes the issue where the gochain was not getting built inside dockerfile * fix: fixes the image tagging Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com> * adds installation instructions * adds package name * adds github workflows * updates version from package * chore: bumps version Co-authored-by: coconut-bunch <ajith.c@outlook.com> Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com> Co-authored-by: ant4g0nist <ant4g0nist@users.noreply.github.com> Co-authored-by: Chaithu <3500559+ant4g0nist@users.noreply.github.com> Co-authored-by: coconut-bunch <ajith.c@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of MIT license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
For checking out the public repository of goloop, we are using the pre-defined action component called
actions/checkout. However, they seems to have a bug where the GitHub token is being required even while cloning a public repo. This happens even when running locally with act (issue)The suggested fix just does a normal git clone operation which seems to work just fine.
Fixes:
#5