Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issuer #205

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fix issuer #205

merged 3 commits into from
Jun 28, 2024

Conversation

eunsoo-icon
Copy link
Member

No description provided.

@eunsoo-icon
Fix base TX executor not to return an error
07390bf 
- When reward fund transfer failed, emit a failed event without an error return
@eunsoo-icon
Fix issue regulator
1e9b3af
@eunsoo-icon eunsoo-icon self-assigned this Jun 28, 2024
mksong76
mksong76 requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mksong76 mksong76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log the failure. Maybe later, we might need to refund it.
Your original idea is better than mine :)

@eunsoo-icon eunsoo-icon merged commit 23c77d4 into master Jun 28, 2024
2 checks passed
@eunsoo-icon eunsoo-icon deleted the fix-issuer branch June 28, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mksong76 mksong76 mksong76 approved these changes

@sink772 sink772 Awaiting requested review from sink772

@goldworm-icon goldworm-icon Awaiting requested review from goldworm-icon

Assignees

@eunsoo-icon eunsoo-icon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunsoo-icon @mksong76