Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Hotfix 1.4.3 #313

Merged
merged 2 commits into from
Aug 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.4.2
1.4.3
4 changes: 2 additions & 2 deletions iconservice/iiss/reward_calc/ipc/message.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
from iconservice.base.address import Address
from iconservice.utils.msgpack_for_ipc import MsgPackForIpc, TypeTag

_next_msg_id: int = 0
_next_msg_id: int = 1


def _get_next_id() -> int:
global _next_msg_id

msg_id: int = _next_msg_id
_next_msg_id = (msg_id + 1) % 0xffffffff
_next_msg_id = max(1, (msg_id + 1) % 0xffffffff)

return msg_id

Expand Down
25 changes: 25 additions & 0 deletions tests/iiss/ipc/test_message.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import unittest

from iconservice.iiss.reward_calc.ipc import message


class TestMessage(unittest.TestCase):
def test_get_next_id(self):
assert message._next_msg_id == 1

msg_id: int = message._get_next_id()
assert msg_id == 1
assert message._next_msg_id == 2

msg_id: int = message._get_next_id()
assert msg_id == 2
assert message._next_msg_id == 3

message._next_msg_id = 0xffffffff
msg_id: int = message._get_next_id()
assert msg_id == 0xffffffff
assert message._next_msg_id == 1

msg_id: int = message._get_next_id()
assert msg_id == 1
assert message._next_msg_id == 2