This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1029: Array Optimization hotfix #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cow-hs
commented
Mar 10, 2020
cow-hs
commented
- cache prefix_hash_key
* cache prefix_hash_key
goldworm-icon
suggested changes
Mar 11, 2020
iconservice/database/db.py
Outdated
|
|
||
| return b'|'.join(data) | ||
| return b''.join((self.prefix_hash_key, key)) |
There was a problem hiding this comment.
Suggested change
| return b''.join((self.prefix_hash_key, key)) | |
| return b'|'.join((self.prefix_hash_key, key)) |
iconservice/database/db.py
Outdated
| @@ -384,6 +384,14 @@ def __init__(self, | |||
| self._context_db = context_db | |||
| self._observer: Optional[DatabaseObserver] = None | |||
|
|
|||
| self.prefix_hash_key: bytes = self._make_prefix_hash_key() | |||
There was a problem hiding this comment.
Suggested change
| self.prefix_hash_key: bytes = self._make_prefix_hash_key() | |
| self._prefix_hash_key: bytes = self._make_prefix_hash_key() |
* self.prefix_hash_key -> self._prefix_hash_key * Remove concatenation operator "+" from _make_prefix_hash_key() * Change an error message in DictDB: "Not Supported iter function on DictDB" -> "Iteration not supported in DictDB"
goldworm-icon
approved these changes
Mar 11, 2020
goldworm-icon
added a commit
that referenced
this pull request
Apr 10, 2020
* Merge hotfix patch into develop branch * IS-1015: Adjust the number of transactions in a block by execution time * IS-1024: Add sha_256 function for SCORE development * IS-1029: Array Optimization hotfix (#424) * IS-1042: fix Fee 2.0 bug * Prevent DictDB iteration officially
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.