This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1112: Allow list and dict as score parameter #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Jul 1, 2020
•
goldworm-icon
commented
- List and TypedDict are available for score parameter
- Refactor IconScoreBaseMeta and IconScoreBase
- Verify internal call arguments
* Put TODO comments to the locations of some codes that are needed to be fixed for score param conversion
* Unittest does not work
* Rename ConstBitFlag to ScoreFlag * Change type from IntEnum to Flag * Add functions for ScoreFlag management
* Fix a minor bug in IconScoreBase.__is_func_readonly()
* Remove useless unittests
* Fix minor bugs in test_element.py * Optimize code
* Some unitests remain failed * Revision handling is needed
* New params type conversion caused some unittest failures. * One unittest still remains failed
* Fix unittest failures caused by IconScoreEngine._convert_score_params_by_annotations()
* Add ScoreFlag.FALLBACK * Add unittest
* Applying new type conversion to on_install and on_update is under development * verify_internal_call_arguments is under development
* Bugfix normalize_signature() * Add normalize_return_annotation()
* All subclasses and functions associated with ScoreElement are also renamed
* Parameter type check on internal call is under development
yakkle
reviewed
Jul 2, 2020
* a: int = None -> a: Union[int, None] = None * Add is_struct_valid() and check_if_struct_is_valid()
* Fix a bug in merge_arguments * Replace dict with OrderedDict in str_to_object()
* 3 tests remain failed
* Revision handling * Fix unittest failures
* Deny Dict type as SCORE parameter * Bugfix in set_default_value_to_params() * Add related unittests
goldworm-icon
deleted the
IS-1112-allow-list-and-dict-as-score-parameter
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.