This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1120: Prevalidate a TX more strictly #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunsoo-icon
approved these changes
Sep 14, 2020
goldworm-icon
suggested changes
Oct 6, 2020
| create_tx_hash().hex(), | ||
| ] | ||
| ) | ||
| def test_origin_request_execute( |
There was a problem hiding this comment.
This unit-test has a critical problem.
It seems to work well but in fact origin_request is always empty dictionary and any checking codes are not executed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a draft to review.
I'm going to full sync after confirm that PR.
include IS-1123 bug fix
Content
Append validate logic about
TODO
There is the plan to append validate logic about SCORE Call after merge this.