This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
IS-1107: Refactor score database and container #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Oct 30, 2020
goldworm-icon
commented
- Change final key generation mechanism
- Add unit-tests for ContainerDB and new IconScoreDatabase
- Clean up unused codes
goldworm-icon
force-pushed
the
IS-1107-refactor-score-database-and-container
branch
2 times, most recently
from
b6bdc6a
to
196847a
Compare
* Add rlp functions
* Bugfix in ScoreDatabase and PrefixScoreDatabase * Apply new databases to ArrayDB
* Apply ScoreDatabase and PrefixScoreDatabase to DictDB
* database.db -> iconscore.db
* Fix some errors caused by ContainerDB refactoring
* Move IconScoreDatase to iconscore package * Update final key generation logic * Update step charge logic * Clean up codes
* There are some scores which use 4-depth DictDB
* Fix a bug in IconScoreDatabase.delete()
* Add the last_key of which value is b"" to a final_key generation * TxIndex: 9
* Add DUMMY to KeyType class
goldworm-icon
force-pushed
the
IS-1107-refactor-score-database-and-container
branch
from
f165b86
to
5c21e3d
Compare
goldworm-icon
deleted the
IS-1107-refactor-score-database-and-container
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.