You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While #31 added exception handlers to catch exceptions thrown by updates to Ridley metrics, it doesn't cover exceptions thrown within registerMetrics. Thus if a single RidleyMetric fails to be registered, the entire server thread will be aborted. For example, this arises in conjunction with #39.
I think registerMetrics should be refactored to wrap an exception handler around the registration code for a single metric, so that failures prevent that metric from being registered but do not block others from being registered.
The text was updated successfully, but these errors were encountered:
While #31 added exception handlers to catch exceptions thrown by updates to Ridley metrics, it doesn't cover exceptions thrown within
registerMetrics
. Thus if a singleRidleyMetric
fails to be registered, the entire server thread will be aborted. For example, this arises in conjunction with #39.I think
registerMetrics
should be refactored to wrap an exception handler around the registration code for a single metric, so that failures prevent that metric from being registered but do not block others from being registered.The text was updated successfully, but these errors were encountered: