Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerMetrics should catch exceptions #40

Closed
adamgundry opened this issue Aug 10, 2022 · 0 comments · Fixed by #42
Closed

registerMetrics should catch exceptions #40

adamgundry opened this issue Aug 10, 2022 · 0 comments · Fixed by #42

Comments

@adamgundry
Copy link

While #31 added exception handlers to catch exceptions thrown by updates to Ridley metrics, it doesn't cover exceptions thrown within registerMetrics. Thus if a single RidleyMetric fails to be registered, the entire server thread will be aborted. For example, this arises in conjunction with #39.

I think registerMetrics should be refactored to wrap an exception handler around the registration code for a single metric, so that failures prevent that metric from being registered but do not block others from being registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant