Make registering handlers resilient to synchronous exceptions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit wraps every effectful block inside 'registerMetrics' with a handler that will try to catch every synchronous exception so that the whole ridley process won't grind to a halt, but rather the handlers that failed to register will simply be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
This PR refactors
registerMetricsby wrapping each handler's registration function with atryRegistercombinator which will catch synchronous exception which might be raised during registration, avoiding that a single failed registration causes the wholeridleythread to abort.It's slightly unsatisfactory that the
Waicase is a bit of an outlier there, but fixing that would require (I suspect), some more thorough refactoring. I wonder if I should just removeWaidata constructor and simply implement it as aCustomMetric, which might be better here. See also #23 .