Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have implemented a port of iconoir to SolidJS as requested in #221.
The new library is found under the
packages/iconoir-solid-js
and the build scripts are in the appropriatebuild/targets/solid-js
. We have ported all current features including theIconoirContext
, the multiple entry points for each variant... The build process is similar to the vue build process which will generate first the actualsrc
folder with all the icons and theIconoirContext
. Then we build usingvite
, one of the de facto standards for solid-js. The build is done once for the global entry point and then once again for each variant so that we can use:We also build for both ESM and CJS. We have also updated the documentation and kept the MIT license as is.
We are open to feedback to make this happen, and for
iconoir-solid-js
package to be published in NPM.Thank you!
@Level4Tech
P.D: You will also see changes in the
bin/build/lib/ts.js
file. We found a bug where in PowerShell instead of a Linux terminal the react build would fail out of the box due to path normalization.Closes #221