Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for SolidJS #493

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PauMAVA
Copy link

@PauMAVA PauMAVA commented Dec 9, 2024

Hello,

We have implemented a port of iconoir to SolidJS as requested in #221.

The new library is found under the packages/iconoir-solid-js and the build scripts are in the appropriate build/targets/solid-js. We have ported all current features including the IconoirContext, the multiple entry points for each variant... The build process is similar to the vue build process which will generate first the actual src folder with all the icons and the IconoirContext. Then we build using vite, one of the de facto standards for solid-js. The build is done once for the global entry point and then once again for each variant so that we can use:

import { UndoCircle } from 'iconoir-solid-js/solid';
....
import { UndoCircle } from 'iconoir-solid-js/regular';
....
import { UndoCircle, UndoCircleSolid } from 'iconoir-solid-js';

We also build for both ESM and CJS. We have also updated the documentation and kept the MIT license as is.

We are open to feedback to make this happen, and for iconoir-solid-js package to be published in NPM.

Thank you!


@Level4Tech


P.D: You will also see changes in the bin/build/lib/ts.js file. We found a bug where in PowerShell instead of a Linux terminal the react build would fail out of the box due to path normalization.

Closes #221

@paescuj paescuj self-requested a review December 9, 2024 09:22
@paescuj
Copy link
Collaborator

paescuj commented Dec 20, 2024

Thanks for your efforts @PauMAVA! ❤️
Could you grant me access to your branch 1 please, so that I can finalize the PR?

Footnotes

  1. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

@PauMAVA
Copy link
Author

PauMAVA commented Dec 20, 2024

Hello @paescuj!

I have invited you as an Outside Collaborator to the fork. Since the repo is organization-owned, I cannot simply add permissions for only this PR.

imagen

There are some tasks that I consider should be done before merging:

  1. Create a SolidJS icon
  2. Modify the website part of the project to add the icon under the "Available For"
    imagen
  3. Also, SolidJS should be added under the "Libraries" in the documentation section of the website.
    imagen

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] SolidJS library
2 participants