Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title to match SVG #174

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Change title to match SVG #174

merged 2 commits into from
Mar 21, 2023

Conversation

samrobbins85
Copy link
Contributor

This changes from using the baseName to the title exported from simple-icons, making the <title>s in the React components match the underlying SVGs, rather than having the si prefix

@wootsbot
Copy link
Member

@samrobbins85 feel free to add a changeset.

pnpm changeset

this could be a path

@samrobbins85
Copy link
Contributor Author

Thanks @wootsbot, added

@wootsbot wootsbot merged commit 28ca25c into icons-pack:main Mar 21, 2023
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wootsbot wootsbot wootsbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samrobbins85 @wootsbot