Initial iOS Support #556
Merged
Initial iOS Support #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CI BUILD]
Still not sure how I feel about this
[CI BUILD]
mikeage
reviewed
Oct 31, 2023
mikeage
reviewed
Nov 1, 2023
mikeage
approved these changes
Nov 19, 2023
|
We'll leave fastlane for another PR, but was hoping for the zapbox sdk to update so I could resolve the remaining conversation before merging this one |
fixes build issue on android, so removing the code that removed zapbox sdk on unsupported platforms.
Conflicts: .github/workflows/build.yml Assets/Editor/BuildTiltBrush.cs Packages/manifest.json
|
I updated this PR based on the changes I recently made. All of the conflicts were resolved in the merge commit |
mikeage
requested changes
Dec 7, 2023
mikeage
approved these changes
Jan 6, 2024
mikeage
pushed a commit
that referenced
this pull request
Jan 9, 2024
Should fix the issue with Quest 1, will need to find a better fix for changing this on Zapbox. Fixes an issue introduced in #556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an iOS pipeline focused on Zapbox support, with general fixes for iOS-related functionality.
Co-authored-by: Andy Baker andy@andybak.net
The remaining GVR systems have been removed due to incompatibility with iOS. We have switched GVR Audio to use standard unity audio, which we'd need for any modern spatialization system anyways.