-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pre-commit (dotnet, and remove a python warning) #627
Conversation
a9d8616
to
e79053c
Compare
@andybak , can I ask you to try this PR locally (when you're back)? Basically do the following:
And make sure it runs. I think I finally figured out how to get rid of the ugly code to inject a specific version of dotnet-format. It works for me locally and it works in CI, so I'm hopeful.... |
|
Sorry typo in my instructions. It should have said dotnet-format |
Oh - I should have spotted that myself! |
Seems to work:
|
Just checked on my Macbook and that worked fine as well! |
Excellent, thank you! |
Use the system version of
dotnet format
instead of a pre-commit managed version. While this is normally not the best way to use pre-commit, it seems like everyone has it installed anyway, and this will let us use the latest versions without having to do ugly hacks like specifically inject v7.something