Upload Zapbox build to the App Store #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeage
requested changes
Feb 23, 2024
mikeage
reviewed
Feb 23, 2024
|
Was this tested E2E in CI? Maybe do one commit having everything except the actual upload (or maybe do the test with TestFlight instead of app store) just to make sure it all runs (if you did, apologies; I'm just not sure how the delete-artifact step could have passed) |
mikeage
previously requested changes
Feb 23, 2024
|
Incidentally, I think I understand now how to manage developer-id credentials in fastlane too, but I want to wait until this is merged before I refactor #625 to use a git repo instead of secrets. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
mikeage
dismissed
their stale review
I'm happy enough now not to block, but I can't quite approve yet.
mikeage
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically build Zapbox in Xcode and upload to App Store.