Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (and tweak) fastlane issues #632

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Fix (and tweak) fastlane issues #632

merged 7 commits into from
Feb 28, 2024

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Feb 28, 2024

  • Optimize initial setup job(s)
  • Fix generate certificates job to create mobileprovision file
  • Fix path for update_code_signing_settings. Too many iOSes, not enough OpenBrushes, in the path :-)
  • Rename the Zapbox release job

@mikeage mikeage added the infrastructure Build or tooling infrastructure label Feb 28, 2024
@mikeage
Copy link
Member Author

mikeage commented Feb 28, 2024

Note that I also created the mobileprovision file in the keys repo, but you don't see that here; the reason it didn't happen is that we didn't have secrets.IOS_BUNDLE_ID defined at the time the job was run two weeks ago. Now we do.

@mikeage
Copy link
Member Author

mikeage commented Feb 28, 2024

This was tested with running bundle exec fastlane ios build but not the final bundle exec fastlane ios release. I didn't want to push to the appstore from a branch in case there's some versioning that'd get messed up. The only difference is the final job upload_to_app_store

@mikeage
Copy link
Member Author

mikeage commented Feb 28, 2024

Is there any value in exposing the .ipa as an artifact, or is it useless outside of the store and/or testflight?

@mikeage mikeage merged commit 6ac1d21 into main Feb 28, 2024
40 checks passed
@mikeage mikeage deleted the infra/fix_fastlane branch February 28, 2024 16:48
@mikeskydev
Copy link
Member

It's basically useless for anyone who isn't on our developer org and has their device ID registered, thanks Apple!

@mikeage
Copy link
Member Author

mikeage commented Feb 28, 2024

ok, so glad I didn't wait for the answer :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants