Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder navigation UI #689

Merged
merged 41 commits into from
May 2, 2024
Merged

Folder navigation UI #689

merged 41 commits into from
May 2, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Apr 16, 2024

No description provided.

@mikeskydev mikeskydev added the enhancement Feature added label Apr 26, 2024
@andybak andybak marked this pull request as ready for review April 27, 2024 12:39
@andybak
Copy link
Contributor Author

andybak commented Apr 27, 2024

I've only implemented this for the Media library so far and there's a few areas where the UI could be polished - but I think it's good enough to ship.

@andybak andybak marked this pull request as draft April 28, 2024 10:26
@andybak
Copy link
Contributor Author

andybak commented Apr 28, 2024

Quest issues in build. Switching this to draft.

@andybak andybak marked this pull request as ready for review April 30, 2024 08:20
@andybak andybak marked this pull request as draft April 30, 2024 08:22
…gation

# Conflicts:
#	Assets/Prefabs/Panels/ReferencePanel/ReferencePanel.prefab
@andybak andybak marked this pull request as ready for review April 30, 2024 18:45
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but I feel like the font (for the directory name) is a bit too small, at least on my Q2. What do you think?

@andybak
Copy link
Contributor Author

andybak commented May 1, 2024

Works, but I feel like the font (for the directory name) is a bit too small, at least on my Q2. What do you think?

Yeah. I was slightly concerned about that as well as the overly thin lines around the button for each entry. I suggest we get this into the beta and gather feedback for a later PR that adds a bit more finesse to the UI. There's probably a few areas to polish up.

@andybak andybak merged commit 9742358 into main May 2, 2024
42 checks passed
@andybak andybak deleted the feature/folder-navigation branch May 2, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants