Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination for layers UI #698

Merged
merged 9 commits into from
May 1, 2024
Merged

Pagination for layers UI #698

merged 9 commits into from
May 1, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Apr 30, 2024

No description provided.

@andybak andybak marked this pull request as ready for review April 30, 2024 12:59
@andybak
Copy link
Contributor Author

andybak commented Apr 30, 2024

This one turned out to be easier than expected (mainly because I gave up on the idea of a scrollbar UI and went with simple pagination).

Ready to ship in my opinion.

@mikeage mikeage added the enhancement Feature added label May 1, 2024
mikeage
mikeage previously requested changes May 1, 2024
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues:

  1. The layer panel contains room for 7 layers. When I create the 7th layer (i.e., main + 1-6), the button for the next page is enabled immediately, although page 2 is blank. I would expect a blank page not to be displayed.

  2. When removing layers, either via deletion or squashing, the button isn't disabled even when the page is fully gone (i.e., create 10 layers (7 + 3), stay on page 1, delete 5; there should only be 5 layers shown, but the button doesn't disable immediately.

@andybak andybak requested a review from mikeage May 1, 2024 15:36
@mikeage
Copy link
Member

mikeage commented May 1, 2024

Can't test now, but does this fix the active button too? The page count looks good

@andybak andybak merged commit 619b3dd into main May 1, 2024
42 checks passed
@andybak andybak deleted the feature/layer-ui-pagination branch May 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants