Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnityGLTF Shader Variants #714

Merged
merged 1 commit into from
May 16, 2024
Merged

UnityGLTF Shader Variants #714

merged 1 commit into from
May 16, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented May 7, 2024

Ensures the neccesary UnityGLTF shader variants are included in the build.

Background info: KhronosGroup/UnityGLTF#736

@andybak andybak requested review from mikeage and mikeskydev May 7, 2024 07:18
@mikeage
Copy link
Member

mikeage commented May 7, 2024

In general, if you're going to be opening a PR, don't use [CI BUILD] in the commit; it just causes it to build twice (once with (push) and once with (pull_request))

Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this does, but sure, why not :-)

Note that you should delete the Library cache (no need to delete the Package or Python caches) before merging, as I see this triggers more shader compilations at build time.

@andybak andybak merged commit b7b5e13 into main May 16, 2024
52 checks passed
@andybak andybak deleted the fix/unitygltf-shader-variants branch May 16, 2024 12:18
@mikeage mikeage added the enhancement Feature added label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants