Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #77 and #79 #78

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Conversation

dubois
Copy link

@dubois dubois commented Apr 2, 2021

No description provided.

Paul Du Bois added 2 commits April 2, 2021 13:57
This is something to do with visual studio tools for unity

Change-Id: Ie3284f485c4e41879448612ec67058784fa75cc2
Broken by 11e8353; local variable f was being stomped

Change-Id: Ibd53c091f101843fc12e57a096335bec66460df3
@dubois dubois changed the title Address #77 Address #77 and #78 Apr 2, 2021
@dubois dubois changed the title Address #77 and #78 Address #77 and #79 Apr 2, 2021
@mikeskydev mikeskydev added the bugfix Something has been fixed label Apr 2, 2021
Copy link
Contributor

@TimAidley TimAidley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one minor nit. LGTM.

Support/Python/tbdata/brush_lookup.py Outdated Show resolved Hide resolved
Paul Du Bois added 3 commits April 7, 2021 15:15
Change-Id: Ic17285516ec336bb1b4eac87217922154f7ed647
There was another edge case where LinearResample would try to read
one past the end of the array.  Fixed.

Added test for that edge case

Change-Id: I3c7c09a7bde93aceff8816874546c069b3ba99b3
Brush descriptor is null for unknown brushes

Change-Id: I898e84393b07eda2dacd01890cf187667734fc36
@dubois
Copy link
Author

dubois commented Apr 7, 2021

Nit fixed.

@mikeskydev mikeskydev merged commit aa0d073 into icosa-foundation:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants