-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #77 and #79 #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something to do with visual studio tools for unity Change-Id: Ie3284f485c4e41879448612ec67058784fa75cc2
Broken by 11e8353; local variable f was being stomped Change-Id: Ibd53c091f101843fc12e57a096335bec66460df3
TimAidley
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only found one minor nit. LGTM.
mikeage
reviewed
Apr 3, 2021
Change-Id: Ic17285516ec336bb1b4eac87217922154f7ed647
There was another edge case where LinearResample would try to read one past the end of the array. Fixed. Added test for that edge case Change-Id: I3c7c09a7bde93aceff8816874546c069b3ba99b3
Brush descriptor is null for unknown brushes Change-Id: I898e84393b07eda2dacd01890cf187667734fc36
Nit fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.