VB -> C#: Convert Date literals

[kanonrai]

Input code

Public Function foo(Option ByVal date As Date = #1/1/1900#)

Erroneous output

Error message:
System.ArgumentOutOfRangeException: Exception of type 'System.ArgumentOutOfRangeException' was thrown.
Parameter name: value
Actual value was 1/1/1900 12:00:00 AM.
   at ICSharpCode.CodeConverter.CSharp.CommonConversions.GetLiteralExpression(Object value, String valueText)
   at ICSharpCode.CodeConverter.CSharp.VisualBasicConverter.NodesVisitor.VisitLiteralExpression(LiteralExpressionSyntax node)
   at Microsoft.CodeAnalysis.VisualBasic.VisualBasicSyntaxVisitor`1.Visit(SyntaxNode node)

Details

Product in use: vs extension

[GrahamTheCoder]

Thanks for the bug report with minimal example. In most cases it'll be possible to do something like DateTime.Parse("1/1/1900").

In the case of const declarations, they'll need to be made non-const to allow this.

In the case you've shown of optional parameters I'll aim to do something like this:
Jon Skeet seems to say it worked for him

public int foo([Optional, DateTimeConstant(0L)] DateTime date)

where 0L would be the ticks representation of the default value given.
This will need to deal with inlining a const field as well as just constant literals.

If it doesn't work I'll have to use something more like:

public int foo(DateTime? optionalDate = null)
{
    var date = optionalDate ?? DateTime.Parse("1/1/1900");
    // Rest of method body
}

Attributes taking DateTime parameters don't seem to be supported in .NET fortunately