Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1049 by adding a workaround (until Roslyn issue is fixed) #1059

Closed
wants to merge 5 commits into from
Closed

Fix #1049 by adding a workaround (until Roslyn issue is fixed) #1059

wants to merge 5 commits into from

Commits on Dec 8, 2023

  1. update Roslyn 4.2.0 -> 4.8.0 and MsBuild 17.4.0 -> 17.8.3 

    Roslyn 4.7.0/MsBuild 17.7 fixed an issue with `With ByRef` (dotnet/roslyn#68194)
    Timur Kelman authored and Timur Kelman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    421ff60 View commit details
    Browse the repository at this point in the history

  2. add a test case

    Timur Kelman authored and Timur Kelman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    28fcc08 View commit details
    Browse the repository at this point in the history

  3. add a workaround 

    It's only required until dotnet/roslyn#71115 is fixed.
    Timur Kelman authored and Timur Kelman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b0a64e6 View commit details
    Browse the repository at this point in the history

  4. adjust expected ConvertVbLibraryOnly/CharacterizationTestSolution.sln… 

    … file
    Timur Kelman authored and Timur Kelman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    fc6d578 View commit details
    Browse the repository at this point in the history

  5. format CSharp/DataFlowAnalysisExtensions.cs

    Timur Kelman authored and Timur Kelman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    85d9f40 View commit details
    Browse the repository at this point in the history