-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CodeAnalysis 4.2.0 (drop 2017 support) #969
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Needed to upgrade >3.11 to avoid dotnet/msbuild#7873 Needed to downgrade < 4.3 to avoid dotnet/roslyn#63780
493d2db
to
4bc4d6f
Compare
Needed codeanalysis >3.11 to avoid dotnet/msbuild#7873 Needed codeanalysis< 4.3 to avoid dotnet/roslyn#63780
89e74b0
to
afcdbbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed codeanalysis >3.11 to avoid dotnet/msbuild#7873
Needed codeanalysis< 4.3 to avoid dotnet/roslyn#63780
Current (working) solution here just sets the minimum version to VS2022 17.2.
It's been available since May 17, 2022, hopefully this won't be too disruptive to most people.
I found another way by forcing a later version of the system memory library. VS2019 support survives...for now.