Feature Request: Search by abbreviated qualified name #1090 #1119
Conversation
…ming a full name search
|
Thank you for your contribution! I noticed that you never set the Please note that we are currently moving a lot of things around in ILSpy and that I am unable to merge this in the near future. Once we are done, I will merge and adapt your contribution to the other changes. Sorry for the wait! |
|
Oh, that's fine. Yeah, I had currently left it as disabled, as I didn't see a good place to add it. You mentioned "I think it would be best to add an option for this" and so I was wondering if you had an idea for where it should be or if I could just add the option where I see fit? Perhaps by making the search bar smaller and adding an option/dropdown there for searchsettings? |
|
Originally I was thinking about adding a checkbox to the DisplaySettingsPanel to enable or disable the feature in general. Not sure if it's useful to have a short input sequence (like there already is |
|
I've temporarily set the activator to be the prefix "s:" so at least the search will be usable/testable. I'm not yet sure what the best way to integrate DisplaySettingsPanel to SearchStrategies would be without introducing unwanted dependencies. If we can confirm that a checkbox is indeed what we want, I can look into this integration. |
ILSpy/SearchStrategies.cs
Outdated
| @@ -114,14 +116,44 @@ protected virtual bool IsMatch(Func<string, string> getText) | |||
| } | |||
| break; | |||
| default: | |||
| if (text.IndexOf(term, StringComparison.OrdinalIgnoreCase) < 0) | |||
| return false; | |||
| if (term.Length > 2 && term.StartsWith(NoncontiguousSearchPrefix, StringComparison.OrdinalIgnoreCase)) { | |||
There was a problem hiding this comment.
Actually, I think it would be much better to follow the convention and allow a prefix per searchTerm... The prefixes followed by a colon are only for the entity selection. +, - and = control the text parsing mode... I will add ~ as a new "per search term prefix"...
There was a problem hiding this comment.
If that's OK with you... ?
There was a problem hiding this comment.
Yes, that makes sense to me. I have just been a little bit occupied with work and I haven't been able to get back around to this. If you're fine waiting the week, I'll have time this weekend.
|
@TheOneAmir Any update on this? |
…ch Not Matching Last Character Bug
|
Alright, I have changed '~' to be the prefix per search term to enable the 'partial substring search'. It is to be noted that there were a few types and constants which had '~' in them which will no longer be returned. If we wish to retain these searches, the only character for which I didn't find any existing matches is the '@' character (Even + and - have existing matches which are hidden by the prefixed searches). |
|
Thank you! I don't think that the "hiding" of these special characters is a big problem, because a) they occur rarely and b) if you want to find some text that starts with + or - or ~ you can always use "++", "+-" and "+~" or regex search. If needed, we could implement some escape syntax, maybe use |
|
Thank you again for your contribution! |
Added the ability to have partial search matches when fullNameSearch is false and allowNonContiguousMatch is true. It is possible to use the in-word matching even with the full name search but since the full names are quite long, a lot of irrelevant matches are picked up.