Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright & Licensing #101

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Copyright & Licensing #101

merged 1 commit into from
Apr 6, 2016

Conversation

McNeight
Copy link
Contributor

@McNeight McNeight commented Apr 1, 2016

  • Update address of Free Software Foundation, which closes Licensing #91
  • All of the various copyright statements have been consolidated to the following:
    Copyright © 2000-2016 AlphaSierraPapa for the SharpZipLib Team

* Update address of Free Software foundation, which closes icsharpcode#91
* All of the various copyright statements have been consolidated to the following:
Copyright © 2000-2016 AlphaSierraPapa for the SharpZipLib Team
@McNeight
Copy link
Contributor Author

McNeight commented Apr 1, 2016

This also closes #89, and in case it is necessary:

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the #ziplib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@christophwille
Copy link
Member

How about we consolidate a tad more - a single license file, no license header/author headers any more. We did that with other projects too.

@McNeight
Copy link
Contributor Author

McNeight commented Apr 5, 2016

Since some of the files were adapted from the GNU Classpath library, do we want to have the entire library covered by that one license? Or do we want to have everything MIT licensed except for those files?

@christophwille
Copy link
Member

The origins of SharpZipLib... it started out its life as a quick port of Java code (@mkrueger did the original version), and out of respect for this, the identical license was adopted. The origins show insofar as the naming is inconsistent with the .NET naming conventions. (it was originally used in SharpDevelop to compress code completion data, that's why we did in the first place)

We meant to change this long ago (meaning tidy the code), but it never happened. The reason to consider doing this at all was mostly the many people asking about the "weird" license. Yes, having all MIT would be way better contribution-wise as well as end-user wise.

@christophwille christophwille mentioned this pull request Apr 5, 2016
@jfreilly jfreilly merged commit c4f9491 into icsharpcode:master Apr 6, 2016
@jfreilly
Copy link
Member

jfreilly commented Apr 6, 2016

Looks fine

@McNeight McNeight deleted the copyright branch April 6, 2016 05:47
@McNeight McNeight mentioned this pull request Apr 6, 2016
@McNeight McNeight added the enhancement Feature request or other improvements of existing functionality label Apr 14, 2016
@xied75
Copy link
Contributor

xied75 commented May 3, 2016

Regarding the Java legacy, is that still a plan to rewrite/remove those? Given it was done long time ago, (at the time Java was lacking lots of today's modern features, let alone .NET), I feel it should be worth it to simply rewrite all the Java files. If you guys agree we may create an Issue to cover those tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Feature request or other improvements of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licensing
4 participants