Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable tests and switch to dotcover #636

Merged
merged 2 commits into from
May 14, 2021
Merged

Fix unstable tests and switch to dotcover #636

merged 2 commits into from
May 14, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented May 13, 2021

This prevents the code coverage to fluctuate depending on the compressibility of the random data.
It also replaces the opencover + coverlet.collector method with dotcover.

The testing and code coverage for windows was split to another job instead of bundling it together with macos/linux with a lot of conditional steps.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

this prevents the code coverage from varying depending on how
well the random data compresses
@piksel piksel force-pushed the test/dotcover branch 4 times, most recently from 7debd7e to 0fe434b Compare May 13, 2021 14:10
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #636 (b4a5b04) into master (232d690) will increase coverage by 1.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   71.89%   73.30%   +1.40%     
==========================================
  Files          62       68       +6     
  Lines        7667     8311     +644     
==========================================
+ Hits         5512     6092     +580     
- Misses       2155     2219      +64     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Zip/ZipStrings.cs 69.23% <0.00%> (-12.59%) ⬇️
...c/ICSharpCode.SharpZipLib/GZip/GzipOutputStream.cs 87.50% <0.00%> (-3.97%) ⬇️
...CSharpCode.SharpZipLib/Zip/Compression/Inflater.cs 71.62% <0.00%> (-1.69%) ⬇️
...Code.SharpZipLib/Zip/Compression/DeflaterEngine.cs 85.66% <0.00%> (-1.47%) ⬇️
...rc/ICSharpCode.SharpZipLib/GZip/GzipInputStream.cs 71.13% <0.00%> (-1.15%) ⬇️
...ICSharpCode.SharpZipLib/Encryption/PkzipClassic.cs 71.02% <0.00%> (-1.05%) ⬇️
src/ICSharpCode.SharpZipLib/Tar/TarHeader.cs 79.49% <0.00%> (-0.99%) ⬇️
src/ICSharpCode.SharpZipLib/Tar/TarInputStream.cs 55.36% <0.00%> (-0.68%) ⬇️
src/ICSharpCode.SharpZipLib/Zip/ZipEntry.cs 90.90% <0.00%> (-0.57%) ⬇️
src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs 77.31% <0.00%> (-0.50%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232d690...b4a5b04. Read the comment docs.

@piksel piksel merged commit 8c0a169 into master May 14, 2021
@piksel piksel deleted the test/dotcover branch May 14, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant