Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with minizip implementation #74

Merged

Conversation

konstantingolovanov
Copy link

(localHeader ||) was deleted, because actually there is no specific difference with reading sizes between local header & central directory
https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
...
4.4 Explanation of fields
...
4.4.8 compressed size: (4 bytes)
4.4.9 uncompressed size: (4 bytes)
The size of the file compressed (4.4.8) and uncompressed,
(4.4.9) respectively. When a decryption header is present it
will be placed in front of the file data and the value of the
compressed file size will include the bytes of the decryption
header. If bit 3 of the general purpose bit flag is set,
these fields are set to zero in the local header and the
correct values are put in the data descriptor and
in the central directory. If an archive is in ZIP64 format
and the value in this field is 0xFFFFFFFF, the size will be
in the corresponding 8 byte ZIP64 extended information
extra field. When encrypting the central directory, if the
local header is not in ZIP64 format and general purpose bit
flag 13 is set indicating masking, the value stored for the
uncompressed size in the Local Header will be zero.

@McNeight McNeight added the bug label Apr 14, 2016
@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight McNeight mentioned this pull request Apr 14, 2016
@McNeight McNeight added the zip Related to ZIP file format label Apr 15, 2016
@McNeight McNeight merged commit 6de6580 into icsharpcode:master May 9, 2016
@McNeight
Copy link
Contributor

McNeight commented May 9, 2016

Konstantin,

Спасибо за отвечать на запросы, и поблагодарить Вас за Ваш вклад.

-Neil

@icsharpcode icsharpcode locked and limited conversation to collaborators May 9, 2016
@McNeight McNeight modified the milestone: 1.0 May 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug zip Related to ZIP file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants