-
Notifications
You must be signed in to change notification settings - Fork 999
fix: replace uses of obsolete method RNGCryptoServiceProvider
#766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace uses of obsolete method RNGCryptoServiceProvider
#766
Conversation
…h RandomNumberGenerator.Create() in PkzipClassic, ZipFile and ZipOutputStream.
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 74.10% 74.13% +0.02%
==========================================
Files 71 71
Lines 8441 8450 +9
==========================================
+ Hits 6255 6264 +9
Misses 2186 2186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piksel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I actually did this in the v1.4 branch, but this is more explicit and thorough. Thanks!
new RNGCryptoServiceProvider()RNGCryptoServiceProvider
Replace insecure obsolete method (new RNGCryptoServiceProvider()) with RandomNumberGenerator.Create() in PkzipClassic, ZipFile and ZipOutputStream.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.