Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FT-IMU frames conversion #212

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix FT-IMU frames conversion #212

merged 1 commit into from
Jun 10, 2022

Conversation

pattacini
Copy link
Member

This PR fixes a problem we spotted in the conversion between the FT reference frame and the frame of the mounted IMU.

cc @davidetome @simeonedussoni

@traversaro
Copy link
Member

fyi @isorrentino

@pattacini pattacini merged commit 7337b01 into master Jun 10, 2022
@pattacini pattacini deleted the fix/ft-imu branch June 10, 2022 06:47
@traversaro
Copy link
Member

The idea is to release this fix with icub-firmware v1.26.0 / distro v2022.08, right?

@pattacini
Copy link
Member Author

pattacini commented Jun 10, 2022

The PR has already landed on the FW, so it depends on @marcoaccame when he wants to release the fix and thus the latest devel.
We could also think of targeting the upcoming Distro 2022.05.1, if needed.

@traversaro
Copy link
Member

That would be great, but are you ok on shipping in 2022.05.1 (or actually 2022.05.2, 2022.05.1 was released yesterday : ) ) also the other changes that were committed to icub-firmware devel in the meantime, i.e. :

@pattacini
Copy link
Member Author

pattacini commented Jun 10, 2022

The 2 changes you spotted are fine as they pertain to AMC and AMCBLDC internal development, I suppose.
So, first, we need the green light from @marcoaccame.
In the case of 🟢, we should coordinate w/ you and @Nicogene for the correct deliveries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants