-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ergoCubEmotions application even with COMPILE_ergoCubEmotions off #196
Install ergoCubEmotions application even with COMPILE_ergoCubEmotions off #196
Conversation
Since ergoCub was not available, I tested the changes on the ergoCub setup on bench with the Orin NX and they worked smoothly: with this PR the module could be launched via the yarpmanager launched from the laptop, as the other yarpmanager applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need also to add YARP in the installation instructions if it become mandatory
So we go for the solution proposed by @Nicogene? I could modify the README.md in accordance to this change cc @traversaro |
Hi @traversaro @Nicogene. Here 8340017 I applied the required changes and I also modified every CMakeLists copyright (like this). I hope that now it's ok |
As per title, I created this PR to refactor the ergoCubEmotions module to have the ergoCubEmotions xml application for the yarpmanager on ergocub-laptop. In this way, when robotology-superbuild is installed:
ergocub-head
theCOMPILE_ergoCubEmotions
flag is ON, so the module is properly installed to be run on itergocub-laptop
the flag is OFF, but the xml for the yarpmanager is still installed. In so doing, the module can be launched from the laptop (as per all the other applications) attaching to the ergocub-head node.I tried this changes on my laptop. The first time, I installed
ergocub-software
with the flag OFF, I opened the yarpmanager and I tried to launch the module from the configuration file (which is installed now):Since no images and videos are installed, nothing is shown.
Then I rebuilt the repo with the flag ON, I repeated the passages listed above and this time I was able to see the expressions:
I'll take this PR in draft until these changes are tested on the robot.