Add angry emotion and not fullscreem mode to ergoCubEmotions #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rerender angry videos without red border
Nicogene
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Hi @giotherobot, thanks for your contribution, I would await @martinaxgloria review for merging it, since she is the author of ergoCubEmotions
| @@ -31,6 +31,7 @@ bool ErgoCubEmotions::configure(ResourceFinder& rf) | |||
| Bottle &bGroup = rf.findGroup("general"); | |||
| nExpressions = bGroup.find("num_expressions").asInt32(); | |||
| nTransitions = bGroup.find("num_transitions").asInt32(); | |||
| fullscreen = bGroup.find("fullscreen").asBool(); | |||
There was a problem hiding this comment.
So fullscreen by default is false? Is it the intended behaviour?
There was a problem hiding this comment.
In the configuration file it is set to true, so the behaviour on the robot should be unchanged.
martinaxgloria
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add the
angryemotion (just a recolor of theshyemotion), hopefully ergoCub will not be angy at us!In addition, for testing purposes I added the
fullscreenoption to the configuration file. Setting this tofalseallows the emotion to show in a window, for ease of use on a laptop while testing.