-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFM: Strikethrough support #62
GFM: Strikethrough support #62
Conversation
gfm-extra.txt contains edge cases not covered by gfm-spec.txt, and is a temporary staging ground as gfm functionality is implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I left one nitpicky comment. Thank you for your strategic approach to this.
# NOTE(margret): Temporarily copying strikethrough specs | ||
# describe_spec("fixtures/gfm-spec.txt", gfm: true) | ||
|
||
describe_spec("fixtures/gfm-extra.txt", gfm: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your strategic approach here, thank you.
My only suggestion is that this file be named something other than "gfm-extra". How about "working-gfm-spec.txt" or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work for me. I also wanted a file to add GFM specs for stuff that wasn't covered by the normal spec (like leaving ~
if there's only one set around a char). I can split these into two different files as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think it'd be better to leave gfm-spec.txt as-is and instead of bringing pieces over to a new file piecemeal, to mark things in gfm-spec that don't/shouldn't pass as pending. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went with the latter as there are currently only ~36 failing tests in gfm-spec.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request adds GitHub Flavored Markdown (GFM) strikethrough support (
~~hello~~
=>hello).This also adds the
gfm-spec.txt
downloaded from here. To prevent a lot of broken specs that won't be fixed by this PR, the strikethrough specs have been copied togfm-extra.txt
temporarily.