Updating Wind Workshop Case #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c hists as capacities
PaulTalbot-INL
requested changes
Mar 23, 2023
|
not yet, will upload those soon. I plan on having 2 tests: one for the NPP+Wind, another for NPP+Wind+TES+Battery. Each will conduct sweeps and be labeled as heavy tests. I was also thinking of adding an additional subdirectory in gold for "Solutions" to the optimization problem. I did one for both cases. |
PaulTalbot-INL
approved these changes
Mar 30, 2023
JiaZhou-PU
pushed a commit
that referenced
this pull request
Jul 14, 2023
* implementing capacity factors in Component input specs and get_capacity * some more comments for usage of cap factors * adding test for capacity factors, includes script to generate gold values * moving gold file one directory down so tests pass * cosmetic changes * allowing static histories for cap factors, also fixing usage of static hists as capacities * quick assert, capacities must all be positive OR negative * regolding with static history, new npp vom, moving golding script * new static histories for capacity factors test * reimplementing wind case using capacity factors, updating npp vom * updating simple wind workshop case, adding new case with storage * trying coarse optimization for both cases * switching back to sweeps, fewer values * updating tests file, regolding and new opt solutions added * better debug values * new analytic file showing plots, improved opt plots in gold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
#153
What are the significant changes in functionality due to this change request?
Updating current wind case to have capacity factors.
Adding new input script that adds storage: TES and Battery storage.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.