-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for parentheses getting dropped from cell definitions. #491
Conversation
Should we test writing all files out to file at least once and see what changes? |
Eventually, we should test writing out each type of input at least once. This can be done piecemeal, with |
I think this should wait until We already bulk read all valid test inputs through the checker. There's already good machinery for finding all valid input files. I think doing this enmass would be a good idea. We just run the risk of discovering a lot of bugs all at once that might is out of scope for this work I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE
Description
This fixes a bug where parentheses disappear from the geometry definition of a cell. This was because
surfaces.HalfSpace
essentially had no way to store that information, and when it was time to export the geometry would override the old parentheses.This was solved in a few ways.
Operation.GROUP
to replaceOperation._SHIFT
in this context. This was because this will be more visible to users andGROUP
is clearer. Also_SHIFT
is used for certain leaf nodes in complex geometry, and lead to confusion.HalfSpace
to representGROUP
HalfSapce
to ensure thatGROUP
is properly handled on export.To sanity check this logic:
Should be
(1 : 2) 3
not1 : 2 3
Fixes #490
Checklist
TODO