Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CI/CD to keep build artifacts. #644

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Jan 23, 2025

Pull Request Checklist for MontePy

Description

Short CI/CD update to keep at least one set of build artifacts.

Fixes #633


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

Documentation Checklist

  • I have documented all added classes and methods.
  • For infrastructure updates, I have updated the developer's guide.
  • For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--644.org.readthedocs.build/en/644/

@MicahGale MicahGale self-assigned this Jan 23, 2025
@MicahGale MicahGale linked an issue Jan 23, 2025 that may be closed by this pull request
@MicahGale
Copy link
Collaborator Author

You can see the artifacts are saved here: https://github.com/idaholab/MontePy/actions/runs/12931396920?pr=644

@MicahGale MicahGale requested a review from tjlaboss January 23, 2025 14:34
@MicahGale MicahGale changed the title Updated upload artifact to actually run on build. Updated CI/CD to keep build artifacts. Jan 23, 2025
@MicahGale MicahGale merged commit bce95f6 into develop Jan 28, 2025
28 checks passed
@MicahGale MicahGale deleted the 633-store-build-artifacts branch January 28, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store build artifacts
2 participants