Merging for RTES

[wjin33]

No description provided.

[moosebuild]

Job Test, step Sync to remote on c216d7c wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage, step Generate coverage on c216d7c wanted to post the following:

Coverage

	6960b8	#147 c216d7
	Total	Total	+/-	New
Rate	86.16%	63.34%	-22.82%	0.00%
Hits	1301	1301	-	0
Misses	209	753	+544	544

Diff coverage report

Full coverage report

Warnings

• New new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

[moosebuild]

Job Coverage, step Verify coverage on c216d7c wanted to post the following:

The following coverage requirement(s) failed:

• Coverage rate 63.34% is less than the required 85.0%

[wjin33]

@rpodgorney ,still have the same issue!

[rpodgorney]

You should be able to do a commit, don’t do a PR. If it still fails we’ll need MOOSE team help

[wjin33]

OK, let me try that. Not sure if I am allowed to push!

[wjin33]

As I expected, I am not the admin of the repo, cannot commit/push directly. See the following error:

git push -u idaho RTES
remote: Permission to idaholab/falcon.git denied to wjin33.
fatal: unable to access 'https://github.com/idaholab/falcon.git/': The requested URL returned error: 403

[rpodgorney]

@wjin33 you have to add individual files, then commit your changes. Don’t do a push.

Go into RTES branch

git add filename1
git add filename2
…..
git commit -m "Adding files to allow RTES examples to run, closes #147"

[wjin33]

@rpodgorney , those are comments on the local repo; all changes will be saved on the local repo. If not pushed to the remote Git Hub Branch, you will see nothing changes.

Directly adding files to the remote repo via a Web browser is not activated for me.

[rpodgorney]

Left me get with Logan so we can get this taken care of. Sorry for the trouble —sent from my mobile device, please excuse typos or autocorrect errors Robert Podgorney, PhD, PG Directorate Fellow, Subsurface Science Energy and Environment Science and Technology Idaho National Laboratory ***@***.*** | 208-526-1524

…

________________________________ From: Wencheng Jin ***@***.***> Sent: Sunday, October 6, 2024 12:11:37 PM To: idaholab/falcon ***@***.***> Cc: Robert K. Podgorney ***@***.***>; Mention ***@***.***> Subject: Re: [idaholab/falcon] Merging for RTES (PR #147) @rpodgorney<https://github.com/rpodgorney> , those are comments on the local repo; all changes will be saved on the local repo. If not pushed to the remote Git Hub Branch, you will see nothing changes. — Reply to this email directly, view it on GitHub<#147 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWGDT3NODC7TLCBO2UMDT3Z2F4NTAVCNFSM6AAAAABPMFFRHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGUZTCMBRHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[rpodgorney]

@permcody can you help us here? Logan is swamped. @wjin33 made some code changes to support some specific examples, but as you can see from this PR, it doesn't quite meet SQA standard. BUT--he is leaving INL and we need to get this code saved on your servers. I created a new branch for it--but he still can't merge it.

[permcody]

As long as he doesn’t delete his branch on his fork, we won’t lose this. Looks like we have a base problem. I may not have much time in the short term either but can help Maui g sure we don’t lose this.

[wjin33]

Thanks, Cody. Yes, all the new features are now saved on my folk. I am available to help even after I leave INL. I appreciate your help.