Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing FVDrichletBCs to take state #29145

Closed
tanoret opened this issue Nov 26, 2024 · 0 comments · Fixed by #29146
Closed

Allowing FVDrichletBCs to take state #29145

tanoret opened this issue Nov 26, 2024 · 0 comments · Fixed by #29146
Assignees
@tanoret
Labels
C: Framework T: task An enhancement to the software.

Comments

@tanoret
Copy link
Contributor

tanoret commented Nov 26, 2024

Motivation

Currently Dirichlet BCs in the FV framework are hardcoded to use the current state. This is inconvenient if we want Dirichlet BCs to take a previous state of a functor.

Design

Modify the getDirichletBoundaryFaceValue function in MooseVariableFV to use the state provided to this function and extend the boundaryValue getter in Dirichlet BCs to take the state provided to this function. Also, remove the assert that ensures that state.state is 0

Impact

More flexibility when using FV Dirichlet BCs or developing new derived classes from FVDirichletBCs
@tanoret tanoret added the T: task An enhancement to the software. label Nov 26, 2024
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret
Allowing Dirichlet BCs to take state - needed for limiters Refs idaho…
23b3894 
…lab#29145
@tanoret tanoret mentioned this issue Nov 26, 2024
Merged
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret
Allowing Dirichlet BCs to take state - needed for limiters Refs idaho…
460817c 
…lab#29145
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret @grmnptr
Update framework/src/fvbcs/FVFunctionDirichletBC.C Refs idaholab#29145
4b28e93 
Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret @grmnptr
Update modules/navier_stokes/src/fvbcs/INSFVOutletPressureBC.C Refs i…
33da269 
…daholab#29145

Co-authored-by: Peter German <31662443+grmnptr@users.noreply.github.com>
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret
style changes in FVFunctionDirichletBC.C and INSFVOutletPressureBC.C …
4b82ca1 
…Refs idaholab#29145
tanoret added a commit to tanoret/moose that referenced this issue Nov 26, 2024
@tanoret
solving return issues with old states of functions Refs idaholab#29145
7c4962d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanoret tanoret

Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowing Dirichlet BCs to take state - needed for limiters tanoret/moose
2 participants
@tanoret @grmnptr