Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NearestNodeValueAux segfaults on non-nodal variables #29741

Open
GiudGiud opened this issue Jan 24, 2025 · 0 comments
Open

NearestNodeValueAux segfaults on non-nodal variables #29741

GiudGiud opened this issue Jan 24, 2025 · 0 comments
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

Bug Description

The NNValueAux will segfault when used to set a non-nodal variable

Steps to Reproduce

Create a non-nodal auxvariable, try to use a NNValueAux to set it

Impact

Makes us look bad.
Wasted time for users and for me re-running simulations / finding workarounds

[Optional] Diagnostics

No response
@GiudGiud GiudGiud added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jan 24, 2025
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 25, 2025
@GiudGiud
Make NNValueAux a lot safer
2c10587 
- check for nodal variables
- dont seg fault on non-nodal ones
- add support for non-nodal variables
- add more checks
closes idaholab#29741
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 29, 2025
@GiudGiud
Make NNValueAux a lot safer
2ad09bd 
- check for nodal variables
- dont seg fault on non-nodal ones
- add support for non-nodal variables
- add more checks
closes idaholab#29741
zachmprince pushed a commit to zachmprince/moose that referenced this issue Feb 12, 2025
@GiudGiud @zachmprince
Make NNValueAux a lot safer
b3fd6a9 
- check for nodal variables
- dont seg fault on non-nodal ones
- add support for non-nodal variables
- add more checks
closes idaholab#29741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud