Avoid ambiguous subdomain when stitching in test #25146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libMesh stitch_meshes is going to start handling MOOSE "subdomain names are first-class objects, ids might be just autogenerated" behavior safely, in addition to the old libMesh "subdomain ids are first-class objects, names are just expected to be matching" behavior. But in between those categories of case is "one submesh may be treating names as first-class objects, another submesh has a matching id without any name", and we can't figure out any safe thing to do there, so by default now we'll scream and die when we see it. So we definitely don't want to see it in CI. This is all in service of catching bugs like in idaholab#25070, via libMesh/libmesh#3613
GiudGiud
approved these changes
Aug 8, 2023
loganharbour
added
the
PR: Auto Merge
|
Job Coverage on d6460ea wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
|
Job Documentation on d6460ea wanted to post the following: View the site here This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
This is all in service of catching bugs like in #25070, via libMesh/libmesh#3613
Design
libMesh stitch_meshes is going to start handling MOOSE "subdomain names are first-class objects, ids might be just autogenerated" behavior safely, in addition to the old libMesh "subdomain ids are first-class objects, names are just expected to be matching" behavior. But in between those categories of case is "one submesh may be treating names as first-class objects, another submesh has a matching id without any name", and we can't figure out any safe thing to do there, so by default now we'll scream and die when we see it.
So we definitely don't want to see it in CI.
Impact
No impact from this PR, except that we'll be able to merge the libMesh PR.
As of the next libMesh submodule update, if any downstream users have similar ambiguous cases, they'll need to apply a similar fix.