Add a line search in newton solve to find contact point #28149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dont die horribly when it fails refs idaholab#28148
Handle problematic case
|
Job Documentation on 722f6fd wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on 5304267 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
so I looked at this more after talking with @bwspenc we already check that we find a face for every secondary node, so these changes are just weeding out bad faces (previously accepted by not checking the newton tolerance...) Thoughts on the way forward here? I have a 600kb mesh from discussion we could use for a test case. I could probably get it down to 300kb |
|
why is the checking on not having leftover unmatched secondary nodes only done on Jacobian computation? |
Small optimizations in search solves Dont include verbose output for failed searches, we do not need all contact point searches to pass, only one and only the best one
|
ok now there's real failures from rejecting nodes |
|
the warning was added in #9832 |
|
@sveerara why only on Jacobian? |
lindsayad
reviewed
Jul 18, 2024
|
Ok forgot to commit some code |
Add variables to avoid being inconsistent in all the heuristics
GiudGiud
commented
Jul 18, 2024
mesh is reduced to only the problematic area
better while loop format Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
lindsayad
approved these changes
Jul 18, 2024
|
Failures unrelated |
roystgnr
reviewed
Jul 19, 2024
| { | ||
| thisElemInfo.push_back(pen_info); | ||
| p_info.push_back(pen_info); | ||
| } |
There was a problem hiding this comment.
else
break_valgrind_tests_with(MEMORY_LEAK);
I'll put up a fix shortly.
roystgnr
added a commit
to roystgnr/moose
that referenced
this pull request
Jul 19, 2024
Hopefully this fixes our new valgrind errors in next, in a bug apparently introduced by idaholab#28149. Refs idaholab#28148 This code really needs an overhaul to get rid of new/delete everywhere, but I'm trying to make a minimal fix here to get next working ASAP.
N4hom
pushed a commit
to N4hom/moose
that referenced
this pull request
Jul 30, 2024
Hopefully this fixes our new valgrind errors in next, in a bug apparently introduced by idaholab#28149. Refs idaholab#28148 This code really needs an overhaul to get rid of new/delete everywhere, but I'm trying to make a minimal fix here to get next working ASAP.
TheGreatCid
pushed a commit
to TheGreatCid/moose
that referenced
this pull request
Aug 1, 2024
Hopefully this fixes our new valgrind errors in next, in a bug apparently introduced by idaholab#28149. Refs idaholab#28148 This code really needs an overhaul to get rid of new/delete everywhere, but I'm trying to make a minimal fix here to get next working ASAP.
TheGreatCid
pushed a commit
to TheGreatCid/moose
that referenced
this pull request
Aug 14, 2024
Hopefully this fixes our new valgrind errors in next, in a bug apparently introduced by idaholab#28149. Refs idaholab#28148 This code really needs an overhaul to get rid of new/delete everywhere, but I'm trying to make a minimal fix here to get next working ASAP.
Leni-Yeo
pushed a commit
to Leni-Yeo/moose
that referenced
this pull request
Aug 28, 2024
Hopefully this fixes our new valgrind errors in next, in a bug apparently introduced by idaholab#28149. Refs idaholab#28148 This code really needs an overhaul to get rid of new/delete everywhere, but I'm trying to make a minimal fix here to get next working ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont die horribly when it fails
refs #28148
See #28091 and #27934
Note that the line search does not save this input. We still dont converge to the right contact point, and get a warning along with debugging information from libmesh.