-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register data per application and allow arbitrary registration #29143
Merged
+1,323
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganharbour
force-pushed
the
data_better
branch
6 times, most recently
from
November 26, 2024 03:05
b07f365
to
9ecf648
Compare
Job Documentation, step Docs: sync website on 783ba06 wanted to post the following: View the site here This comment will be updated on new commits. |
loganharbour
force-pushed
the
data_better
branch
2 times, most recently
from
November 26, 2024 18:41
0a4dfa7
to
536b0b8
Compare
loganharbour
requested review from
lindsayad,
bwspenc,
dschwen,
jiangwen84 and
roystgnr
as code owners
November 26, 2024 18:43
Job Coverage, step Generate coverage on 783ba06 wanted to post the following: Framework coverage
Modules coverageChemical reactions
Contact
Fluid properties
Heat transfer
Navier stokes
Optimization
Phase field
Porous flow
Reactor
Solid mechanics
Solid properties
Thermal hydraulics
Full coverage reportsReports
This comment will be updated on new commits. |
loganharbour
force-pushed
the
data_better
branch
from
November 27, 2024 01:24
0f81631
to
37a592f
Compare
dschwen
previously approved these changes
Nov 27, 2024
loganharbour
force-pushed
the
data_better
branch
2 times, most recently
from
November 28, 2024 19:00
f30f8e1
to
62b2473
Compare
@dschwen this is ready for review. |
loganharbour
force-pushed
the
data_better
branch
2 times, most recently
from
December 1, 2024 02:49
295ae56
to
5a24cfa
Compare
loganharbour
force-pushed
the
data_better
branch
from
December 1, 2024 02:49
5a24cfa
to
783ba06
Compare
dschwen
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29141
Summary:
DataFileInterface::getDataFileName("param")
and instead sets the param value internally so thatgetParam<DataFileName>("param")
gets you the absolute path to whatever we searchedYou can directly query an application's registered data path with:
In the event that you have ambiguous data, you'll get an error like the following (where you can provide
name:path/to/file
to be explicit)In the event that you're searching from a parameter (you have a base to search from) and nothing is found, you get a useful printout of everything searched, like:
The command line options
--show-data-params
and--show-data-paths
were added so that you can see this info in the header (because we no longer callmooseInfo()
every time we resolve params because it would be too verbose):If the search path starts with
./
it will not search data directories, and you'll get information that this is the case:and the same for when the search path resolves outside of
.
:You can interact directly with the registry to get files (like needed for the NEML case) with: