Skip to content

Commit

Permalink
Fixing things found in review.
Browse files Browse the repository at this point in the history
  • Loading branch information
joshua-cogliati-inl committed Jun 15, 2023
1 parent ab25d3e commit 2e9a3fd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions doc/user_manual/PostProcessors/SparseSensing.tex
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ \subsubsection{SparseSensing}
\item \xmlNode{Goal}, \xmlDesc{string, required field}, the goal of the sparse sensor optimization.
User has to provide \xmlAttr{subType} which is a \xmlDesc{string, required field} representing the goal of the sparse sensing optimization; i.e., which goal function is used in the optimization? Examples for such goal functions are:
\begin{itemize}
\item \textbf{Reconstruction} deals with predicting the values of a quantity of interest at different locations other than those where sensors are located. For example, one might predict the temperature at a point point in the middle of a fuel rod based on readings taken at various other positions.
\item \textbf{Reconstruction} deals with predicting the values of a quantity of interest at different locations other than those where sensors are located. For example, one might predict the temperature at a point in the middle of a fuel rod based on readings taken at various other positions.

\item \textbf{Classification} is the problem of predicting which category an example belongs to, given a set of training data (e.g. determining whether digital photos are of dogs or cats).
\end{itemize}
Expand All @@ -26,7 +26,7 @@ \subsubsection{SparseSensing}
\begin{itemize}
\item \xmlNode{features}, \xmlDesc{comma separated strings, required field}, features/inputs of the data model, i.e., locations or time stamps we should sense
\item \xmlNode{target}, \xmlDesc{comma separated strings, required field}, target of data model
\item \xmlNode{basis} , \xmlDesc{string, optional field}, the type of basis onto which the data are projected: \xmlString{Identity},\xmlString{ SVD}, \xmlString{Random}. \default{SVD}
\item \xmlNode{basis} , \xmlDesc{string, optional field}, the type of basis onto which the data are projected: \xmlString{Identity}, \xmlString{SVD}, \xmlString{Random}. \default{SVD}
\item \xmlNode{nModes}, \xmlDesc{integer, required field}, the number of modes used to project the data.
\item \xmlNode{nSensors}, \xmlDesc{integer, required field}, the number of sensors used
\item \xmlNode{optimizer}, \xmlDesc{string, optional field}, the optimizer used to find the sensors: \xmlString{QR}, \xmlString{CCQR} for unconstrained and cost constrained respectively.
Expand Down
2 changes: 1 addition & 1 deletion ravenframework/Models/PostProcessors/SparseSensing.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _handleInput(self, paramInput):
self.raiseAnError(IOError, '{} is not a recognized option, allowed options are {}'.format(child.getName(),self.goalsDict.keys()))
_, notFound = paramInput.subparts[0].findNodesAndExtractValues(['nModes','nSensors','features','target'])
# notFound must be empty
assert(not notFound)
assert not notFound, "Unexpected nodes in _handleInput"

def run(self,inputIn):
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<name>tests/framework/Postprocessors/SPSL</name>
<author>Mohammad Abdo (@Jimmy-INL)</author>
<created>2022-07-18</created>
<classesTested>Postprocessors.SPSL</classesTested>
<classesTested>Models.Postprocessors.SparseSensing</classesTested>
<description>This test aims to check the ability of the Sparse Sensing Postprocessor
to locate and plot the selected sensors to reconstruct the temperature field of the OPTI-TWIST prototype
when perturbing the heater power.
Expand Down

0 comments on commit 2e9a3fd

Please sign in to comment.