Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessor Restructure #1456

Merged
merged 14 commits into from
Mar 10, 2021
Merged

PostProcessor Restructure #1456

merged 14 commits into from
Mar 10, 2021

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Mar 3, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

See #1451
The PostProcessor base class and the PostProcessor of Model are combined to simplify the PostProcessor structure and enhance the inheritance of PostProcessors. In this way, PostProcessor can directly use MessageHandler, InputData, InputType, and functions from RAVEN Base Class (such as methods to handle metadata).

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 mentioned this pull request Mar 3, 2021
10 tasks
@wangcj05 wangcj05 requested review from alfoa and mandd March 3, 2021 23:44
@wangcj05
Copy link
Collaborator Author

wangcj05 commented Mar 5, 2021

Hi @mandd and @alfoa, could you take a look at this PR?

Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections. (It looks fine to me.)

@wangcj05 wangcj05 force-pushed the wangc/pp_plugin_api_fy21 branch from bc4263e to 7c934e4 Compare March 10, 2021 17:32
Copy link
Collaborator

@mandd mandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me after the last modifications

@mandd
Copy link
Collaborator

mandd commented Mar 10, 2021

All reviews are green, test board is green. Merging

@mandd mandd merged commit 7c8f351 into devel Mar 10, 2021
@alfoa
Copy link
Collaborator

alfoa commented Mar 11, 2021

@wangcj05 can you add more description in the PR ?

@wangcj05 wangcj05 changed the title PostProcessor Clean up PostProcessor Restructure Mar 11, 2021
@wangcj05 wangcj05 added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Mar 11, 2021
@wangcj05
Copy link
Collaborator Author

@alfoa I have updated the description for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants