-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostProcessor Restructure #1456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections. (It looks fine to me.)
bc4263e
to
7c934e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me after the last modifications
All reviews are green, test board is green. Merging |
@wangcj05 can you add more description in the PR ? |
@alfoa I have updated the description for this PR. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
See #1451
The PostProcessor base class and the PostProcessor of Model are combined to simplify the PostProcessor structure and enhance the inheritance of PostProcessors. In this way, PostProcessor can directly use MessageHandler, InputData, InputType, and functions from RAVEN Base Class (such as methods to handle metadata).
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.