Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NetCDF Databases #1459

Merged
merged 14 commits into from
Mar 9, 2021
Merged

Adds NetCDF Databases #1459

merged 14 commits into from
Mar 9, 2021

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Mar 4, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1320
Closes #1463

What are the significant changes in functionality due to this change request?

Adds NetCDF as a database storage option.

  • Cleanup and modularization of Databases module
  • Differentiation between base class Database and HDF5
  • Implementation of Database.NetCDF
  • Addition of NetCDFDiffer for testing
  • Moves NetCDF writing compatibility from DataSet to new database

Also

  • Extends some of the rook documentation for user clarity
  • Renames obtuse variables in Simulation for easier comprehension and maintenance

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from alfoa March 4, 2021 19:07
@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Mar 5, 2021
9 tasks
Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and Modifications for the NetCDF database are good as they are. No comment there. Modifications that are not functional to this PR should be reverted (addition of diffs that are just cosmetic)

@alfoa
Copy link
Collaborator

alfoa commented Mar 8, 2021

@PaulTalbot-INL , is the error in #1320 caught now ? PS. Can you add an issue specific for the addition of netCDF support and tag it with "future RAVEN v 2.1"?

@PaulTalbot-INL PaulTalbot-INL added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Mar 8, 2021
@PaulTalbot-INL
Copy link
Collaborator Author

That's a good point, it doesn't prevent that error if the user applies HDF5. I changed the "close" to a new issue.

@alfoa
Copy link
Collaborator

alfoa commented Mar 8, 2021

@PaulTalbot-INL do you think it is possible to error out in case of HDF5? (It should be something like if DO.type not in ['PointSet','HistorySet']: self.raiseAnError() right?

@PaulTalbot-INL
Copy link
Collaborator Author

Yup, think I caught both. This would be a much better cross-test for a good validator, but for now at least the user should get a reasonable error.

@alfoa alfoa mentioned this pull request Mar 8, 2021
10 tasks
@alfoa
Copy link
Collaborator

alfoa commented Mar 8, 2021

PR Approved...

Checklist passed...

Merging once tests pass...

@alfoa
Copy link
Collaborator

alfoa commented Mar 9, 2021

Test passed.

Merging...

@alfoa alfoa merged commit 57bd6b5 into idaholab:devel Mar 9, 2021
@alfoa alfoa deleted the netcdf4 branch March 9, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Mixed-Dimension Databases [TASK] Database should be able to store DataSet
2 participants