-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds NetCDF Databases #1459
Adds NetCDF Databases #1459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR and Modifications for the NetCDF database are good as they are. No comment there. Modifications that are not functional to this PR should be reverted (addition of diffs that are just cosmetic)
@PaulTalbot-INL , is the error in #1320 caught now ? PS. Can you add an issue specific for the addition of netCDF support and tag it with "future RAVEN v 2.1"? |
That's a good point, it doesn't prevent that error if the user applies HDF5. I changed the "close" to a new issue. |
@PaulTalbot-INL do you think it is possible to error out in case of HDF5? (It should be something like if DO.type not in ['PointSet','HistorySet']: self.raiseAnError() right? |
Yup, think I caught both. This would be a much better cross-test for a good validator, but for now at least the user should get a reasonable error. |
PR Approved... Checklist passed... Merging once tests pass... |
Test passed. Merging... |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1320
Closes #1463
What are the significant changes in functionality due to this change request?
Adds NetCDF as a database storage option.
Databases
moduleDatabase
andHDF5
Database.NetCDF
NetCDFDiffer
for testingDataSet
to new databaseAlso
rook
documentation for user claritySimulation
for easier comprehension and maintenanceFor Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.