Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization Path Plotter #1507

Merged
merged 27 commits into from
Jun 22, 2021
Merged

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Apr 8, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1506

What are the significant changes in functionality due to this change request?

Adds a OutStreams.Plot subType for plotting optimization results.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from Jimmy-INL April 8, 2021 22:30
@PaulTalbot-INL PaulTalbot-INL added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Apr 8, 2021
@alfoa alfoa self-requested a review April 8, 2021 23:21
alfoa
alfoa previously requested changes Apr 15, 2021
@@ -80,7 +81,7 @@
</GAparams>

<convergence>
<objective>-1</objective>
<AHDp>0.1</AHDp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not in the manual. @Jimmy-INL

Copy link
Collaborator Author

@PaulTalbot-INL PaulTalbot-INL Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed from the test change, or should we put off the GA demonstration for another PR? @Jimmy-INL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it

Copy link
Collaborator

@Jimmy-INL Jimmy-INL Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please convert it back to <objective>-1</objective>? If the test is long reduce the <limit>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't affect the plotter at all. Sorry, I thought it is hanging because other tests are failing not because of this. My bad, I think I am losing my memory

@PaulTalbot-INL
Copy link
Collaborator Author

I fixed the generation script and added the updated docs. It looks like quite a few options were hiding in the InputSpecs that hadn't made it into the docs.

This is one more big sign that we should try to automate all the docs, I suppose.

@PaulTalbot-INL
Copy link
Collaborator Author

@Jimmy-INL this is passing tests still; I merged in devel to resolve some conflicts. Where are we at with this PR?

@moosebuild
Copy link

Job Test OpenSUSE Leap 15 on 7851b4f : invalidated by @Jimmy-INL

@PaulTalbot-INL PaulTalbot-INL dismissed alfoa’s stale review June 22, 2021 18:41

concerns have been resolved

@Jimmy-INL
Copy link
Collaborator

The openSuSE Leap 15 machine is currently down. I am merging this after discussion with @PaulTalbot-INL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Optimization visualization
4 participants