-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization Path Plotter #1507
Conversation
@@ -80,7 +81,7 @@ | |||
</GAparams> | |||
|
|||
<convergence> | |||
<objective>-1</objective> | |||
<AHDp>0.1</AHDp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in the manual. @Jimmy-INL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed from the test change, or should we put off the GA demonstration for another PR? @Jimmy-INL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please convert it back to <objective>-1</objective>
? If the test is long reduce the <limit>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't affect the plotter at all. Sorry, I thought it is hanging because other tests are failing not because of this. My bad, I think I am losing my memory
I fixed the generation script and added the updated docs. It looks like quite a few options were hiding in the InputSpecs that hadn't made it into the docs. This is one more big sign that we should try to automate all the docs, I suppose. |
@Jimmy-INL this is passing tests still; I merged in devel to resolve some conflicts. Where are we at with this PR? |
Job Test OpenSUSE Leap 15 on 7851b4f : invalidated by @Jimmy-INL |
The openSuSE Leap 15 machine is currently down. I am merging this after discussion with @PaulTalbot-INL |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1506
What are the significant changes in functionality due to this change request?
Adds a
OutStreams.Plot
subType
for plotting optimization results.For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.