Added setAddtionalParams method to externalROMLoader

[AnthoneyGriffith]

---

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#1856

What are the significant changes in functionality due to this change request?

Added method to externalROMloader that has xml nodes as inputs for changing the pickledROM attributes of the ROM. Alongside this is a test showing the ability to change the clusteredEvalMode of the ROM with this new method.

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added is the the analytic documentation updated/added?
• 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

[wangcj05]

@AnthoneyGriffith could you follow the raven code standards? This applies to all the methods. This is required for any PR. You can check the link: https://github.com/idaholab/raven/wiki/RAVEN-Software-Commentary-Standard

[AnthoneyGriffith]

Thank you for pointing those out! I believe I have changed all of them to the correct styling.

[PaulTalbot-INL]

We're set to update the submodule in RAVEN soon; do you think we'll have this merged soon so we can include it?

[wangcj05]

PR looks good.

[wangcj05]

@PaulTalbot-INL @dylanjm anyone want to merge it?

[joshua-cogliati-inl]

@AnthoneyGriffith @dylanjm Hm, how is tests/framework/ROM/pickleTests/externalROMloader/arma.pk generated? At some point we will need to update it.

[dylanjm]

@joshua-cogliati-inl That's a good catch. @AnthoneyGriffith is there a way we can add the training XML and data to RAVEN?

[joshua-cogliati-inl]

Thanks for adding generating the arma.pk file in #1878