Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for parallel coordinate plot #1915

Merged
merged 15 commits into from
Nov 18, 2022
Merged

fixes for parallel coordinate plot #1915

merged 15 commits into from
Nov 18, 2022

Conversation

mandd
Copy link
Collaborator

@mandd mandd commented Jul 26, 2022 •
edited by wangcj05
Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1914
Closes #1916

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@mandd mandd requested a review from Jimmy-INL July 26, 2022 23:36
@mandd mandd requested a review from wangcj05 July 27, 2022 15:12
wangcj05
wangcj05 requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two minor comments for your consideration.

ravenframework/Samplers/Grid.py Outdated
@@ -108,6 +108,13 @@ def localInputAndChecks(self, xmlNode, paramInput):
self.raiseAnError(IOError, 'inconsistency between number of variables and grid specification')
self.axisName = list(grdInfo.keys())
self.axisName.sort()
print(grdInfo)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote print?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, removed

ravenframework/Samplers/Grid.py Outdated
if grdInfo[key][0] == 'CDF':
valueArrays = grdInfo[key][2]
if min(valueArrays)<0.0 or max(valueArrays)>1.0:
self.raiseAnError(IOError, ("Grid associated with distribution " + str(key) + " is outside the [0,1] interval"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add more information in the Error? Such as the grid node associated with which variable under which Grid sampler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wangcj05 wangcj05 mentioned this pull request Jul 28, 2022
Open
4 tasks
wangcj05
wangcj05 previously approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

@wangcj05
Copy link
Collaborator

PR checklist passed, once tests are green, PR can be merged.

@wangcj05
Copy link
Collaborator

@mandd Some tests failed on Mingw and Ubuntu 18 PIP. I guess you need to change the tolerance for the image comparison.

@moosebuild
Copy link

Job Test Ubuntu 18 PIP on 22c8019 : invalidated by @mandd

@moosebuild
Copy link

Job Mingw Test on 22c8019 : invalidated by @mandd

@moosebuild
Copy link

All jobs on 22c8019 : invalidated by @wangcj05

retesting

wangcj05
wangcj05 reviewed Aug 11, 2022
View reviewed changes
doc/workshop/optimizer/GeneticAlgorithms/Inputs/tests
@@ -2,6 +2,7 @@
[./GA_MaxwRep]
type = 'RavenFramework'
input = '1_GA_MaxwRep.xml'
image = 'MaxwReplacement/plotter1.png'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to provide a tolerance for image diff, since this test failed on windows. @mandd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wangcj05 wangcj05 added the RAVENv2.3 for RAVEN 2.3 Release label Nov 16, 2022
wangcj05
wangcj05 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@moosebuild
Copy link

Job Test qsubs sawtooth on 05138de : invalidated by @wangcj05

tests/cluster_tests/InternalParallel/test_hybrid_model_code failed

@wangcj05
Copy link
Collaborator

PR looks good, and checklist is satisfied.

@wangcj05 wangcj05 merged commit a90aa2a into devel Nov 18, 2022
@wangcj05 wangcj05 deleted the mandd/plotFixes branch November 18, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangcj05 wangcj05 wangcj05 approved these changes

@Jimmy-INL Jimmy-INL Awaiting requested review from Jimmy-INL

Assignees
No one assigned
Labels
defect priority_normal RAVENv2.3 for RAVEN 2.3 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Add Check on grid object for grid sampler [DEFECT] Parallel coordinate plot issue
4 participants
@mandd @wangcj05 @moosebuild @joshua-cogliati-inl