-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New melcor interface #1997
Conversation
@mattdon The Precheck failed: Run the "delete_trailing_whitespace.sh" script in your raven/developer_tools/ directory. ERROR: RAVEN prefers two spaces instead of tabs. The following files contain tab characters: |
Job Test qsubs sawtooth on 446f280 : canceled by @wangcj05 no need to test |
@mattdon FYI, The melcor test failed: |
To make it run, some additional nodes must be added to the RAVEN XML input. |
@mattdon Could you able to update the test to reflect your suggestions? |
Job Mingw Test on 6deb3ab : canceled by @joshua-cogliati-inl will fail due to conda issue. |
This is a duplicated PR for #2017. I will close it. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
The MELCOR interface has been merged into a single python module. The finalize_code_output uses an external git code developed at the Sapienza University of Rome to directly extract output variables from the MELCOR PLT file.
What are the significant changes in functionality due to this change request?
Users can use this new code interface that can output MELCOR variables associated with different packages (CVH, FL, COR, RN, ESF, etc.). Users should add an XML node to the RAVEN input deck listing all the variables to be used as output.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.