Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FARM submodule, With 2023 FORCE training files #2104

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Update FARM submodule, With 2023 FORCE training files #2104

merged 1 commit into from
Apr 16, 2023

Conversation

wanghy-anl
Copy link
Contributor

@wanghy-anl wanghy-anl commented Apr 13, 2023


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

See #1114

What are the significant changes in functionality due to this change request?

Added the slides and files for 2023 FORCE training


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wanghy-anl
Copy link
Contributor Author

@wangcj05 Hey Congjian, I saw the "Test qsubs sawtooth" was marked failed. I did some test on my own computers, finding that all the tests in FARM and HERON could pass on my windows machine; However, 21 HERON tests and 4 FARM tests failed on my mac machine. These 4 failed FARM tests call HERON. Do you see the similar failures on your side? My raven is on the latest commit c3c8a78 and HERON is the submodule version (commit b316024). Let me know if you need more info from my side.

@moosebuild
Copy link

Job Test qsubs sawtooth on af45b8b : invalidated by @wangcj05

job canceled due to npc issue.

@wangcj05
Copy link
Collaborator

wangcj05 commented Apr 14, 2023 via email

@wanghy-anl
Copy link
Contributor Author

Thank you Congjian. Let me know if you need me to change any code from my side. Haoyu

@moosebuild
Copy link

All jobs on af45b8b : invalidated by @wangcj05

testing with resolved library conflicts

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@moosebuild
Copy link

Job Test qsubs sawtooth on af45b8b : invalidated by @wangcj05

@wangcj05
Copy link
Collaborator

Tests are good, PR can be merged.

@wangcj05 wangcj05 merged commit 92cf89a into idaholab:devel Apr 16, 2023
@wanghy-anl wanghy-anl deleted the wanghy/UpdateFarmSubmodule2023ForceTraining branch April 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants