-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FARM submodule, With 2023 FORCE training files #2104
Update FARM submodule, With 2023 FORCE training files #2104
Conversation
@wangcj05 Hey Congjian, I saw the "Test qsubs sawtooth" was marked failed. I did some test on my own computers, finding that all the tests in FARM and HERON could pass on my windows machine; However, 21 HERON tests and 4 FARM tests failed on my mac machine. These 4 failed FARM tests call HERON. Do you see the similar failures on your side? My raven is on the latest commit c3c8a78 and HERON is the submodule version (commit b316024). Let me know if you need more info from my side. |
Job Test qsubs sawtooth on af45b8b : invalidated by @wangcj05 job canceled due to npc issue. |
It seems there are some issues with HERON plugins, I will talk with HERON developers to fix them.
Congjian
…________________________________
From: Haoyu Wang ***@***.***>
Sent: Thursday, April 13, 2023 9:57 PM
To: idaholab/raven ***@***.***>
Cc: Congjian Wang ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [idaholab/raven] Update FARM submodule, With 2023 FORCE training files (PR #2104)
@wangcj05<https://github.com/wangcj05> Hey Congjian, I saw the "Test qsubs sawtooth" was marked failed. I did some test on my own computers, finding that all the tests in FARM and HERON could pass on my windows machine; However, 21 HERON tests and 4 FARM tests failed on my mac machine. These 4 failed FARM tests call HERON. Do you see the similar failures on your side? My raven is on the latest commit c3c8a78<c3c8a78> and HERON is the submodule version (commit b316024). Let me know if you need more info from my side.
—
Reply to this email directly, view it on GitHub<#2104 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABX3L373D6ZL2U6QSXXWZITXBDDJRANCNFSM6AAAAAAW5H7IRE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thank you Congjian. Let me know if you need me to change any code from my side. Haoyu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.
Job Test qsubs sawtooth on af45b8b : invalidated by @wangcj05 |
Tests are good, PR can be merged. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
See #1114
What are the significant changes in functionality due to this change request?
Added the slides and files for 2023 FORCE training
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.