Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds VARMA model to the TSA module #2180

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Adds VARMA model to the TSA module #2180

merged 2 commits into from
Oct 4, 2023

Conversation

j-bryan
Copy link
Collaborator

@j-bryan j-bryan commented Sep 11, 2023


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#2179

What are the significant changes in functionality due to this change request?
  • Adds VARMA model to the TSA module. This will allow users to create models using the TSA module (e.g. SyntheticHistory ROM) that model correlated target variables. This is a significant feature that has been missing in the TSA module and is one of the last major features needed to bring the SyntheticHistory ROM to feature parity with the ARMA ROM.
  • Fixes a bug in the interpolation of the ARMA model. The variance terms and initial state distribution of the ARMA model was not being interpolated between macro steps. This behavior was hidden due to the relevant test interpolating between two identical models. The test has been updated so that the interpolation happens between models with different parameter values.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Mingw Test on fb5901b : invalidated by @j-bryan

@moosebuild
Copy link

Job Test Ubuntu 18 PIP on 4371684 : invalidated by @dylanjm

Retry LOGOS plugin test

@j-bryan j-bryan requested a review from dylanjm September 21, 2023 12:34
dylanjm
dylanjm previously approved these changes Sep 28, 2023
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and no additional comments to address.

@j-bryan j-bryan dismissed dylanjm’s stale review September 28, 2023 19:34

The merge-base changed after approval.

@moosebuild
Copy link

Job Mingw Test on 4371684 : invalidated by @dylanjm

Retry running to get the failed test results

@moosebuild
Copy link

Job Mingw Test on 4371684 : invalidated by @dylanjm

Rerun to get the error folders

dylanjm
dylanjm previously approved these changes Oct 3, 2023
@j-bryan j-bryan dismissed dylanjm’s stale review October 3, 2023 18:04

The merge-base changed after approval.

dylanjm
dylanjm previously approved these changes Oct 3, 2023
@j-bryan j-bryan dismissed dylanjm’s stale review October 3, 2023 18:09

The merge-base changed after approval.

@dylanjm dylanjm merged commit e5b0862 into idaholab:devel Oct 4, 2023
@dylanjm dylanjm mentioned this pull request Oct 4, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants