Combined remove smt, update numpy, and unpin cloudpickle #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is identical to #2363 except related commits have been squashed together. |
wangcj05
reviewed
Sep 10, 2024
Comment on lines
+195
to
+196
| initSamples = lhs(limits.shape[0], samples=nSamples, criterion='cm', random_state=42) | ||
| initSamples = limits[:,0] + (limits[:,1] - limits[:,0]) * initSamples |
There was a problem hiding this comment.
I suggest to make a util function for these lines since they appears multiple times and in different modules.
There was a problem hiding this comment.
We can fix that in new PR; as there are too many things going on here.
|
Job Mingw Test on e5e417f : invalidated by @joshua-cogliati-inl failed in set python environment with segfault |
1 similar comment
|
Job Mingw Test on e5e417f : invalidated by @joshua-cogliati-inl failed in set python environment with segfault |
|
Job Test qsubs sawtooth on e5e417f : invalidated by @joshua-cogliati-inl Diff tests/cluster_tests/test_mpiqsub_nosplit |
9 tasks
9 tasks
This was referenced Sep 10, 2024
PaulTalbot-INL
approved these changes
Sep 10, 2024
This was
linked to
issues
Sep 10, 2024
4 tasks
|
Checklists pass. Merging. |
joshua-cogliati-inl
deleted the
combined_smt_numpy_cloudpickle_rebase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
Issue #2355
Issue #2294
What are the significant changes in functionality due to this change request?
The SMT library is currently not functioning on macOS. However, we only require it for a specific function that can be utilized through the pyDOE3 library
This updates to Numpy 1.24
This removes the pinning to cloudpickle 2.2
These are combined because they are all needed to pass the regression tests.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.